Merged
Conversation
kevinjqliu
force-pushed
the
kevinjqliu/auto-update-docker-image
branch
from
55630b4 to
f87dc66
Compare
geruh
approved these changes
Jan 6, 2026
Contributor
geruh
left a comment
geruh
left a comment
There was a problem hiding this comment.
Yeah this makes sense for development. Thanks @kevinjqliu!
Fokko
approved these changes
Jan 6, 2026
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Nice one @kevinjqliu 🙌 Thanks for the review @geruh
Fokko
pushed a commit
that referenced
this pull request
Jan 6, 2026
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
New Iceberg Version.
Relates to #2885
Let's get #2885 in before this PR
## Are these changes tested?
## Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
This was referenced Jan 12, 2026
kevinjqliu
added a commit
to apache/iceberg-rust
that referenced
this pull request
Jan 19, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## What changes are included in this PR? Similar to apache/iceberg-python#2885 Add the `--build` flag to `docker compose up`. This will trigger docker to rebuild if the docker-compose file or the Dockerfile is changed. Without `--build`, changes to `Dockerfile` will not trigger a new image build and we might accidentally still be using the old image thinking its updated <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> --------- Co-authored-by: Renjie Liu <liurenjie2008@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add the
--buildflag todocker compose up. This will trigger docker to rebuild if the docker-compose file or the Dockerfile is changed.This is useful when we need to change the
ICEBERG_VERSIONin dev/spark/Dockerfile.Previously,
make integrationwill not pick up the newICEBERG_VERSIONchange. It will only be picked up by rebuilding the image explicitly withmake test-integration-rebuild.With this PR, the
ICEBERG_VERSIONwill be picked up automatically. The new Iceberg jar will be downloaded and the rest of the docker artifacts will be cached.Are these changes tested?
Yes, locally using
ICEBERG_VERSION=1.10.1Are there any user-facing changes?
No